maokaihe/mini_lsm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: typos & refine comments (#65)

Browse Source 
* typo in  week2-01-compaction.md

* chroe: typos & add comments

* chore: more typos

* Update week2-01-compaction.md

---------

Co-authored-by: Alex Chi Z <iskyzh@gmail.com>
This commit is contained in:
0x29a
2024-03-25 03:23:07 +08:00
committed by GitHub
parent afad25b6fd
commit 621d7a8cf3
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mini-lsm-book/src/week2-01-compaction.md
View File

@@ -66,7 +66,7 @@ Because we always compact all SSTs, if we find multiple version of a key, we can
There are some things that you might need to think about.
* How does your implementation handle L0 flush in par with compaction? (Not taking the state lock when doing the compaction, and also need to consider new L0 files produced when compaction is going on.)
* How does your implementation handle L0 flush in parallel with compaction? (Not taking the state lock when doing the compaction, and also need to consider new L0 files produced when compaction is going on.)
* If your implementation removes the original SST files immediately after the compaction completes, will it cause problems in your system? (Generally no on macOS/Linux because the OS will not actually remove the file until no file handle is being held.)
## Task 2: Concat Iterator

2
mini-lsm-book/src/week2-04-leveled.md
View File

@@ -63,7 +63,7 @@ In addition, at most *one* level can have a positive target size below `base_lev
0 0 30MB 300MB 3GB 30GB
```
Notice in this case L1 and L2 have target size of 0, and L3 is the only level with a postive target size below `base_level_size_mb`.
Notice in this case L1 and L2 have target size of 0, and L3 is the only level with a positive target size below `base_level_size_mb`.
### Task 1.2: Decide Base Level